Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event_trigger to cloud functions #2158

Merged

Conversation

rileykarson
Copy link
Collaborator

@rileykarson rileykarson commented Oct 3, 2018

Deprecate old trigger_ objects, and retry_on_failure.

Decisions:

  • Let's over-required on failure_policy.retry to stop weird configs
  • resource expects mostly a partial self link, except gcs buckets use a different shape of self link. The shape Cloud Functions expect is not that shape. The shape they use is made up, so there is an error if you supply a gcs self link... let's be restrictive and only allow names for now. We need to specify the shape if we take in names, so we need to match against specific event_types. So let's only support the two trigger types we supported before for now (Cloud Storage, Cloud Pub/Sub)
  • Note for the future: Formats are documented here
  • event_type accepts a specific pattern that is documented. It will also accept some different formats (at least a certain subset of the pattern) and is not as restrictive as it seems, but let's not document that because the Cloud Functions documentation does not. And also we need users to match specific shapes so we can format the self links correctly.

@ghost ghost added the size/xl label Oct 3, 2018
@paddycarver paddycarver added this to the 1.19.0 milestone Oct 4, 2018
@paddycarver paddycarver merged commit 3294d7e into hashicorp:master Oct 4, 2018
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
…ent-trigger

Add event_trigger to cloud functions
@ghost
Copy link

ghost commented Nov 16, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants