Allow ENTERPRISE_PLUS as default Edition for POSTGRES_16 #19977
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current default:
ENTERPRISE
forsettings.edition
is not consistent with the API which treatsEDITION_UNSPECIFIED
as the default (refer link) when customer doesn't provide any. With PostgreSQL version 16, the default Edition will beENTERPRISE_PLUS
as documented in the PostgreSQL June 07, 2024 release notes. Thus, unset the defaultedition
so that it can instead be computed in the API, allowing the API to useENTERPRISE_PLUS
as the default for POSTGRES_16.b/338258663
I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#12077