Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored deps #1967

Merged
merged 5 commits into from
Sep 18, 2018
Merged

Update vendored deps #1967

merged 5 commits into from
Sep 18, 2018

Conversation

SirGitsalot
Copy link
Collaborator

I'm working on Stackdriver monitoring in another branch, which required updating google.golang.org/genproto, which required updating google.golang.org/grpc, which required updating github.com/golang/protobuf, and so on. This PR updates all of the Google-provided deps to their latest versions. In addition, there is:

  • A change in config.go to reflect an updated type name
  • Five files changed by make fmt

Tested with make build, make test, and make testacc.

@ghost ghost added the size/xxl label Aug 30, 2018
@SirGitsalot
Copy link
Collaborator Author

Updated to remove some stale deps that made make vendor-status barf.

@danawillow
Copy link
Contributor

Oh dang that's a lot of updates! It also looks like travis still failed, mind checking that out? Once that's fixed, I'll kick off a full test suite run on this since it's a change that has the capability of breaking a lot of things.

@danawillow danawillow self-requested a review September 5, 2018 21:31
@rileykarson
Copy link
Collaborator

rileykarson commented Sep 5, 2018

Looks like the make fmt issues are because of a gofmt change between Go 1.10 and Go 1.11. Try downgrading your Go version to fix those!

Personally, I used (with homebrew on MacOS)

brew install [email protected]

Then set these environment variables in my .bashrc:

export GOROOT=~/homebrew/opt/[email protected]/libexec/bin
export PATH="~/homebrew/opt/[email protected]/bin:$PATH"

We're upgraded to Go 1.11 after #1994 so once you're merged/rebased you should be golden for make fmt stuff.

@ghost ghost added the size/xxl label Sep 12, 2018
@SirGitsalot
Copy link
Collaborator Author

Travis build fixed.

@nat-henderson
Copy link
Contributor

I'm running the tests on this branch on CI. :)

@nat-henderson
Copy link
Contributor

Oh, I never came back around to this - LGTM. Some server errors and flakes on the test run but nothing serious.

@SirGitsalot
Copy link
Collaborator Author

@danawillow @ndmckinley I don't have write access, so merge please :-)

@danawillow danawillow merged commit 771c2f8 into hashicorp:master Sep 18, 2018
@ghost
Copy link

ghost commented Nov 16, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants