Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ACM version to highest valid version number #18683

Conversation

modular-magician
Copy link
Collaborator

Current supported versions are 1.16.0, 1.16.1, 1.16.2, 1.16.3, 1.17.0, 1.17.1, 1.17.2, 1.17.3, 1.18.0, 1.18.1, 1.18.2

This will fix an error happening 100% since May:

Error: Error creating FeatureMembership: googleapi: Error 400: InvalidValueError for field version: unsupported ACM version 1.15.1 for Membership projects/PROJECT_NUMBER/locations/global/memberships/tf-test1jorkx1127k, supported versions are 1.16.0, 1.16.1, 1.16.2, 1.16.3, 1.17.0, 1.17.1, 1.17.2, 1.17.3, 1.18.0

By updating the version we're likely to unmask some non-empty plan test failures that were occurring previously in the test history

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#11110

[upstream:07fb117adfe662240e7719aa03c1cc63761ea34b]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 7cacfec into hashicorp:main Jul 9, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2024
@modular-magician modular-magician deleted the downstream-pr-07fb117adfe662240e7719aa03c1cc63761ea34b branch November 17, 2024 00:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant