Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#17030] NGFW: Add securityProfileGroup argument tests to hierarchical and network firewall policies #18237

Conversation

modular-magician
Copy link
Collaborator

[Please, wait before merging] adding tlsInspect argument tests as well

  • Adds acceptance tests for google_compute_network_firewall_policy_rule resource
  • Adds acceptance tests for the securityProfileGroup argument in google_compute_firewall_policy_rule and google_compute_network_firewall_policy_rule resources

Fixes hashicorp/terraform-provider-google/issues/17030.

compute: Added acceptance tests for `google_compute_network_firewall_policy_rule`
compute: Added acceptance tests for the `securityProfileGroup` argument in `google_compute_firewall_policy_rule` and `google_compute_network_firewall_policy_rule` resources

Derived from GoogleCloudPlatform/magic-modules#10598

…erarchical and network firewall policies (hashicorp#10598)

Co-authored-by: Luca Prete <[email protected]>

[upstream:559e39ca44e5a1102b2895c3e60945451fb75b71]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit a04a740 into hashicorp:main May 23, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
@modular-magician modular-magician deleted the downstream-pr-559e39ca44e5a1102b2895c3e60945451fb75b71 branch November 17, 2024 00:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add securityProfileGroup and tlsInspect in firewall policy Rule
1 participant