Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failing tests TestAccBigQueryJob_bigqueryJobCopy* #17970

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -490,9 +490,13 @@ func TestAccBigQueryJob_bigqueryJobCopyExample(t *testing.T) {

func testAccBigQueryJob_bigqueryJobCopyExample(context map[string]interface{}) string {
return acctest.Nprintf(`
locals {
count = 2
}

resource "google_bigquery_table" "source" {
deletion_protection = false
count = length(google_bigquery_dataset.source)
count = local.count

dataset_id = google_bigquery_dataset.source[count.index].dataset_id
table_id = "tf_test_job_copy%{random_suffix}_${count.index}_table"
Expand All @@ -519,7 +523,7 @@ EOF
}

resource "google_bigquery_dataset" "source" {
count = 2
count = local.count

dataset_id = "tf_test_job_copy%{random_suffix}_${count.index}_dataset"
friendly_name = "test"
Expand Down Expand Up @@ -645,9 +649,13 @@ func TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample(t *testing.T) {

func testAccBigQueryJob_bigqueryJobCopyTableReferenceExample(context map[string]interface{}) string {
return acctest.Nprintf(`
locals {
count = 2
}

resource "google_bigquery_table" "source" {
deletion_protection = false
count = length(google_bigquery_dataset.source)
count = local.count

dataset_id = google_bigquery_dataset.source[count.index].dataset_id
table_id = "tf_test_job_copy%{random_suffix}_${count.index}_table"
Expand All @@ -671,10 +679,12 @@ resource "google_bigquery_table" "source" {
}
]
EOF

depends_on = [google_bigquery_dataset.source]
}

resource "google_bigquery_dataset" "source" {
count = 2
count = local.count

dataset_id = "tf_test_job_copy%{random_suffix}_${count.index}_dataset"
friendly_name = "test"
Expand Down
8 changes: 6 additions & 2 deletions website/docs/r/bigquery_job.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -304,9 +304,13 @@ resource "google_bigquery_job" "job" {


```hcl
locals {
count = 2
}

resource "google_bigquery_table" "source" {
deletion_protection = false
count = length(google_bigquery_dataset.source)
count = local.count

dataset_id = google_bigquery_dataset.source[count.index].dataset_id
table_id = "job_copy_${count.index}_table"
Expand All @@ -333,7 +337,7 @@ EOF
}

resource "google_bigquery_dataset" "source" {
count = 2
count = local.count

dataset_id = "job_copy_${count.index}_dataset"
friendly_name = "test"
Expand Down