Fix Stretch Private Cloud creation in vmwareengine #17875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:71d5293f31bbbbd98a7e073050e4f52e092fa964] Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
modular-magician
deleted the
downstream-pr-71d5293f31bbbbd98a7e073050e4f52e092fa964
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some resource refactoring and bug fixes based on the manual testing of Stretch PCs and is a continuation of #10340. These changes were manually tested by performing CRUD operations on a Stretch Private Cloud using terraform.
Please note that currently stretch private clouds need at least 6 nodes (for context, a majority of current vmareengine resource tests use a 1 node PC). Further, it is currently only supported in 3 regions, and all of them are full with customer nodes. Hence, it would not be possible to nightly run stretch PC tests on Terraform.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10443