Fix tests to use dedicated bootstrapped service accounts instead of one shared account #17873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne shared account (hashicorp#10418) [upstream:7041d8052bd61acf8a05feb51cdccf950ff072e6] Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
modular-magician
deleted the
downstream-pr-7041d8052bd61acf8a05feb51cdccf950ff072e6
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16247
Previously, one shared service account was bootstrapped and reused for at least 2 of these tests. During the bootstrap, which is called on every VCR run, the policy on the service account was designed to be overwritten (to control for drift). However, overwriting the policy is a read-modify-write operation that cannot be done concurrently. This creates a race condition when the bootstrap functions are run at the same time, which seems to be more common in the VCR case.
The solution chosen here is to create a separate service account per-test. Service accounts are cheap, there are only 5 such uses for them so far, and this allows us to enforce the policy on every run the way we do now. Since the accounts are isolated per-test, they can still be bootstrapped ahead of time, while not running into concurrency issues.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10418