Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add credentials_secret field in azure blob storage block for google storage transfer job resource #17563

Conversation

modular-magician
Copy link
Collaborator

Modifies the handwritten config for google_storage_transfer_job resource to add the credentials_secret field in the azure_blob_storage_data_source block.

Note the credentials_secret field is in preview, so the change will only be present in the beta provider

Fixes: #16263

Note to reviewer: There are no existing tests which cover the fields in thetransfer_spec.azure_blob_storage_data_source block. Please advise on how to proceed!

Release Note Template for Downstream PRs (will be copied)

storagetransferservice: added field `transfer_spec.azure_blob_storage_data_source.credentials_secret` to `google_storage_transfer_job` (beta)

Derived from GoogleCloudPlatform/magic-modules#9278

…ogle storage transfer job resource (hashicorp#9278)

* feat: add `credentials_secret` in `azure_blob_storage_data` source config

* feat: add version guard for `credentials_secret` as in preview

* docs: add documentation on `credentials_secret`

[upstream:4555c3364bb74d340fb13db281fc79bd8f862249]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 7b3ae2b into hashicorp:main Mar 13, 2024
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
@modular-magician modular-magician deleted the downstream-pr-4555c3364bb74d340fb13db281fc79bd8f862249 branch November 17, 2024 00:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant