Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity: Refactor config tests #17460

Conversation

modular-magician
Copy link
Collaborator

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#9956

* Add test util for locating a subproject 2 layers deep

* Refactor tests to use new helper function

* Consolidate testing of service sweeper builds, refactor `getSubProject` to return non-nullable value

* Refactor new sweeper tests

[upstream:59e75bc22744a97d6d7bdaaba2d6e0e4d4a6d9cc]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 0ab0161 into hashicorp:main Mar 1, 2024
4 checks passed
SarahFrench pushed a commit that referenced this pull request Mar 1, 2024
* Add test util for locating a subproject 2 layers deep

* Refactor tests to use new helper function

* Consolidate testing of service sweeper builds, refactor `getSubProject` to return non-nullable value

* Refactor new sweeper tests

[upstream:59e75bc22744a97d6d7bdaaba2d6e0e4d4a6d9cc]

Signed-off-by: Modular Magician <[email protected]>
Copy link

github-actions bot commented Apr 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
@modular-magician modular-magician deleted the downstream-pr-59e75bc22744a97d6d7bdaaba2d6e0e4d4a6d9cc branch November 17, 2024 00:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant