Add fine grained resource for instance group membership #17188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add fine-grained resource * Add InstanceGroupMembership resource * add acceptance tests for the resource * Add message to the resource * Fix trailing spaces * Fix trailing spaces * Add zone to test * Add zone to test * Review fixes - change fields labels, update descriptions and indentation * Undo mistake change * Remove flatten from the encoder * Remove "Region" prefix in the test files and decoder, as it could be replaces with the existingfill_to_relative_path custom_flatten [upstream:40e92edbde12b2fe291c50860dfe2f06684d933d] Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
modular-magician
deleted the
downstream-pr-40e92edbde12b2fe291c50860dfe2f06684d933d
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fine-grained
instance_group_membershipresource as an alternative way of addinginstanceto aninstance_groupto avoidinstance_groupresource inconsistency afterinstancerecreation.This change will be added to both google and google-beta provider versions.
instance_group_membershipaccepts onlyinstanceandinstance_groupfields.Bug: fixes #8605
Bug: #9930
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9891