netapp_storage_pool: Improve example code #17140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s pick up the right thing to do (hashicorp#9892) [upstream:0767aacd3f074addbf06a59df80aa919e4062da8] Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
modular-magician
deleted the
downstream-pr-0767aacd3f074addbf06a59df80aa919e4062da8
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users tend to copy the example code for resources and start their customisation from there. The example code was missing a google_compute_network_peering_routes_config resource which makes sure the routing is updated.
While this doesn't have any impact on the NetApp Volumes service itself, it may cause connectivity issues for clients.
It also adds a few comments to the example code to make them aware of some VPC peering basics they need to consider (and to often don't).
While adding these comments seems a bit off-topic, I strongly believe they are relevant to decrease the demand for support tickets.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9892