Add "server_ca_cert" Attribute reference #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documents the addition of the `server_ca_cert` attribute for use in configuring SSL with GCP SQL Instances - added in PR #1020
rosbo
suggested changes
May 29, 2018
| @@ -231,6 +231,17 @@ when the resource is configured with a `count`. | |||
|
|
|||
| * `settings.version` - Used to make sure changes to the `settings` block are | |||
| atomic. | |||
|
|
|||
| * `server_ca_cert.0.cert` - The CA Certificate used to connect to the SQL Instance via SSL | |||
There was a problem hiding this comment.
Can you use the same format than the other configuration blocks?
See how this is done for the settings field.
|
Let me know if you have any questions :) And thanks for the contribution |
Updates formatting to match the above fields.
|
@rosbo I updated the formatting to match the above fields and cleaned up the wording a bit. Let me know if you need anything else. |
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
* Add "server_ca_cert" Attribute reference Documents the addition of the `server_ca_cert` attribute for use in configuring SSL with GCP SQL Instances - added in PR hashicorp#1020 * Updated formatting Updates formatting to match the above fields.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the addition of the
server_ca_certattribute for use in configuring SSL with GCP SQL Instances - added in PR #1020