Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for node pool versions #1266

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Conversation

danawillow
Copy link
Contributor

Fixes #633.

--- PASS: TestAccContainerNodePool_version (918.80s)

@danawillow
Copy link
Contributor Author

This felt way too easy though so please do try to find something I might have missed :P

Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, I don't see anything that you missed? It looks great to me!

@danawillow danawillow merged commit 33d87a2 into hashicorp:master Mar 29, 2018
@danawillow danawillow deleted the is-633 branch March 29, 2018 20:27
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
@ghost
Copy link

ghost commented Nov 19, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for version upgrades in google_container_node_pool
3 participants