Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DiffSuppress for google_sql_database_instance on disk_type #12374

Closed
wants to merge 1 commit into from

Conversation

NA2047
Copy link

@NA2047 NA2047 commented Aug 24, 2022

Potential fix for #10492

@github-actions
Copy link

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@NA2047 NA2047 marked this pull request as ready for review August 24, 2022 20:19
@github-actions github-actions bot requested a review from melinath August 24, 2022 20:19
Copy link
Collaborator

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this will be reusable; for now it might be preferable to have a very specific diff suppress func for this field that uses strings.Replace to convert dashes to underscore - unless the API supports any delimiter?

If a specific diff suppress func would work, it should be defined in the resource file instead of the common file.

Either way - please add some unit tests for the diff suppress func. See common_diff_suppress_test.go for examples. Thanks!

@NA2047 NA2047 closed this Aug 30, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants