Remove redundant privateca cert authority tests #12205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #12138 (but not sure it's gonna be quite enough)
There's fairly thorough coverage of state management in privateca's ca resource, which is nice-to-have but the global limit on the number of CAs (see #12198 for some discussion around similar limits) and the 30d deletion period mean reducing the total count we provision is valuable. Here's why I cut each of these:
We can likely bootstrap the CA used for the datasource and cert tests as well, which would further remove 4 CAs/run.
Oh, also remove
privateca_quickstart
from the CA pool docs- it doesn't have tests, and it's really a configuration we'd include against the cert resource normally.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6338