Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant privateca cert authority tests #12205

Conversation

modular-magician
Copy link
Collaborator

Partially addresses #12138 (but not sure it's gonna be quite enough)

There's fairly thorough coverage of state management in privateca's ca resource, which is nice-to-have but the global limit on the number of CAs (see #12198 for some discussion around similar limits) and the 30d deletion period mean reducing the total count we provision is valuable. Here's why I cut each of these:

  • TestAccPrivatecaCertificateAuthority_rootCaIsEnabledByDefault appears to just be a case where we used a basic config and checked a value, so move the check to the start of TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityUpdate (which starts in the same place)
  • TestAccPrivatecaCertificateAuthority_rootCaCreatedInStaged is redundant with the first step of TestAccPrivatecaCertificateAuthority_rootCaManageDesiredState
  • TestAccPrivatecaCertificateAuthority_subordinateCaCreatedInAwaitingUserActivation , TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation, are each checking the value of an output-only field as returned by the API

We can likely bootstrap the CA used for the datasource and cert tests as well, which would further remove 4 CAs/run.

Oh, also remove privateca_quickstart from the CA pool docs- it doesn't have tests, and it's really a configuration we'd include against the cert resource normally.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#6338

@modular-magician modular-magician merged commit 1335e01 into hashicorp:main Jul 29, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2022
@modular-magician modular-magician deleted the downstream-pr-dab1f196be87962b436a422da0ef5e4433b2a40c branch November 17, 2024 02:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant