Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing labels field to google_compute_instance documentation #12182

Conversation

modular-magician
Copy link
Collaborator

Closes #11774

PR adds labels to the supported fields in the initialize_params block documentation (currently not in the docs)

Description copied from the code:

https://github.com/GoogleCloudPlatform/magic-modules/blob/c2a78c7a9296eaf813677bea9fd8f1469aef43f8/mmv1/third_party/terraform/resources/resource_compute_instance.go.erb#L217

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests). N/A
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know). N/A
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#6326

@modular-magician modular-magician merged commit 9715c78 into hashicorp:main Jul 26, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
@modular-magician modular-magician deleted the downstream-pr-2b60d6f4b7cde1c7de9f60b00335a14cc6a12ee8 branch November 17, 2024 02:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"labels" are supported but missing from boot_disk.initialize_params docs
1 participant