Add support for disk interface in google_compute_instance

[jbarbuto]

This allows specifying the disk interface as documented at
https://cloud.google.com/compute/docs/reference/latest/instances#resource-representations

It addresses #24

$ make testacc TESTARGS='-run=TestAccComputeInstance_local_ssd'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccComputeInstance_local_ssd -timeout 120m
?   	github.com/terraform-providers/terraform-provider-google	[no test files]
=== RUN   TestAccComputeInstance_local_ssd
--- PASS: TestAccComputeInstance_local_ssd (66.80s)
=== RUN   TestAccComputeInstance_local_ssd_nvme
--- PASS: TestAccComputeInstance_local_ssd_nvme (64.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	130.834s

[jbarbuto]

Would it be preferable to enforce the persistent disk restriction in the terraform code?

[jbarbuto]

This builds off the effort in hashicorp/terraform#13026 which appears to have been abandoned 😕

[catsby]

Hi there! Thanks for opening this. I'm wondering if this conflicts with #123 , do you have any thoughts?

[jbarbuto]

Appears so yes, I'm fine with closing this PR then. Glad to see it implemented in some form or another 🎉

[danawillow]

Thanks @jbarbuto! Hope I didn't waste too much of your time :(

[jbarbuto]

@danawillow No worries, it was a good opportunity to learn Terraform internals which may come in handy later :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!