Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute reservation terraform sample for C.G.C #12037

Conversation

modular-magician
Copy link
Collaborator

Adding documentation for https://cloud.google.com/compute/docs/instances/reservations-single-project

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#6217

* Compute reservation terraform sample for C.G.C

* Removed Beta version to use only GA versions

* updated to resolve possible blocker

* Updated the erb file

* Corrected for test runs

* Added correct project env parameter

* Removed additional spaces

* Renamed file for tests to run

* Update terraform.yaml

Added skip_import_test config for workaround

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 1cc0ca5 into hashicorp:main Jul 6, 2022
@github-actions
Copy link

github-actions bot commented Aug 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
@modular-magician modular-magician deleted the downstream-pr-0f699a7468d0070c9208dd56a2410b4d61575ea1 branch November 17, 2024 00:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant