Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generated resources for http(s)_health_check, updates to backend_bucket, and import helpers #1177

Merged
merged 6 commits into from
Mar 10, 2018

Conversation

danawillow
Copy link
Contributor

(I separated the changes out into logical commits, but let me know if you want me to separate out the PRs too)

@danawillow danawillow requested a review from rosbo March 9, 2018 23:35
if err != nil {
return handleNotFoundError(err, d, fmt.Sprintf("HTTP Health Check %q", d.Get("name").(string)))
return err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update our magic module to handle 404 in delete properly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't usually do 404 checking in deletes, since hypothetically the refresh would have caught it and removed the resource from state. Do you have an example resource that does?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this resource, look at the diff

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's diffing it against read() because the order of the functions changed

Copy link
Contributor

@rosbo rosbo Mar 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@danawillow
Copy link
Contributor Author

Pushed a quick commit with some fixes that came up in the test run. All TestAccCompute tests are passing now. Going to go ahead and merge because the fixes are just putting back things that were accidentally left out.

@danawillow danawillow merged commit edf8918 into hashicorp:master Mar 10, 2018
@danawillow danawillow deleted the mm branch March 10, 2018 01:14
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
…bucket, and import helpers (hashicorp#1177)

* add import helpers for generated code

* Updates to backend bucket and transport.go from MM

* add generated http(s)_health_check resources

* name is required; transport import style

* update docs with new fields/timeouts

* fixes
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost unassigned rosbo Mar 29, 2020
@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants