Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 10386 #10541

Closed
wants to merge 2 commits into from
Closed

fix: 10386 #10541

wants to merge 2 commits into from

Conversation

c4po
Copy link

@c4po c4po commented Nov 10, 2021

for #10386

 make testacc TEST=./google TESTARGS='-run=TestAccEssentialContactsContact_update'

==> Checking source code against gofmt...
==> Checking that code complies with gofmt requirements...
go generate  ./...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccEssentialContactsContact_update -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccEssentialContactsContact_update
=== PAUSE TestAccEssentialContactsContact_update
=== CONT  TestAccEssentialContactsContact_update
--- PASS: TestAccEssentialContactsContact_update (37.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-google/google	39.447s

@github-actions github-actions bot requested a review from slevenick November 10, 2021 19:23
@slevenick
Copy link
Collaborator

The essential contacts resource is generated from another repo called Magic Modules. It helps us keep this provider in sync with the Google beta provider.

Can you make this PR against that repo instead? Instead of editing the resource file you will need to edit a YAML file, and then copy this test over.

You can add the line input: true to this block: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/products/essentialcontacts/api.yaml#L56 which corresponds to the field being marked ForceNew. The test can then be placed in https://github.com/GoogleCloudPlatform/magic-modules/tree/master/mmv1/third_party/terraform/tests and it should generate an identical change

@c4po
Copy link
Author

c4po commented Nov 17, 2021

@slevenick is this looks ok? GoogleCloudPlatform/magic-modules#5461

@slevenick
Copy link
Collaborator

I merged the upstream PR, so this fix should now exist on master and this PR can be closed

@slevenick slevenick closed this Nov 22, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants