Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use pull_request_target in reviewer lottery #10388

Merged
merged 1 commit into from
Oct 27, 2021
Merged

use pull_request_target in reviewer lottery #10388

merged 1 commit into from
Oct 27, 2021

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Oct 25, 2021

Looks like we're able to use pull_request_target now, so switched back to this.

Reference: uesteibar/reviewer-lottery@5531ef7

@megan07 megan07 requested a review from bflad October 25, 2021 14:34
bflad
bflad approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reviewer-lottery changes good to me -- verified upstream changes and new commit SHA. 🚀 I'm a little hazy whether removing contents: read will work in this context, I think it will, but it may need to be put back.

@megan07 megan07 merged commit e427812 into master Oct 27, 2021
@megan07 megan07 mentioned this pull request Nov 11, 2021
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@megan07 @bflad