Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make route priority optional, default to 1000 #1015

Merged
merged 2 commits into from
Jan 30, 2018

Conversation

jphalip
Copy link
Contributor

@jphalip jphalip commented Jan 27, 2018

Fixes #1009

@emilymye
Copy link
Contributor

Looks good to me! Could you also change the docs to show that priority is default? Thank you!

@jphalip
Copy link
Contributor Author

jphalip commented Jan 30, 2018

@emilymye Sure, just updated the doc. Thanks!

@emilymye
Copy link
Contributor

Awesome, thanks!

make testacc TEST=./google TESTARGS='-run=TestAccComputeRoute_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccComputeRoute_basic -timeout 120m
=== RUN TestAccComputeRoute_basic
--- PASS: TestAccComputeRoute_basic (62.68s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google62.864s

@emilymye emilymye merged commit db3a88e into hashicorp:master Jan 30, 2018
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route resource's priority parameter should be optional
2 participants