Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert google_dns_record_set to previous implementation #10089

Conversation

modular-magician
Copy link
Collaborator

Fixes #9257
Fixes #9112
Fixes #9416

This PR reverts the resource to the original handwritten version that uses the DNS client library from the MM-generated version that used the new API.

Deviations from the old handwritten version include:

  • More tests
  • ttl was made optional in the previous iteration, I am keeping it optional for backwards-compatibility
  • reset the resource ID after updating. The type field can be updated which is a part of the ID. This allows one of the newer tests to import correctly

Release Note Template for Downstream PRs (will be copied)

dns: fixed an issue in `google_dns_record_set` where creating the resource would result in an 409 error
dns: fixed an issue in `google_dns_record_set` where `rrdatas` could not be updated

Derived from GoogleCloudPlatform/magic-modules#5191

@modular-magician modular-magician merged commit d8268c7 into hashicorp:master Sep 16, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2021
@modular-magician modular-magician deleted the downstream-pr-13be49e14700121c0b3b294c223816fcc89acd8c branch November 17, 2024 02:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant