Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ResourceIamPolicy for google_project_iam_policy #777

Closed
rosbo opened this issue Nov 21, 2017 · 6 comments · Fixed by GoogleCloudPlatform/magic-modules#3410, #6200 or hashicorp/terraform-provider-google-beta#1996

Comments

@rosbo
Copy link
Contributor

rosbo commented Nov 21, 2017

Once the deprecated authoritative boolean field is removed from the google_project_iam_policy resource. Reuse the common ResourceIamPolicy.

@rileykarson
Copy link
Collaborator

rileykarson commented Oct 19, 2018

This is no longer breaking and no longer necessarily has to happen in 2.0.0 with GoogleCloudPlatform/magic-modules#581.

@rileykarson rileykarson removed this from the 2.0.0 milestone Oct 19, 2018
@paddycarver
Copy link
Contributor

I think GoogleCloudPlatform/magic-modules#605 means this is done, right @rileykarson?

@rileykarson
Copy link
Collaborator

Nope - it wouldn't be a breaking change anymore, but we aren't using ResourceIamPolicy yet.

@paddycarver
Copy link
Contributor

Can we still use ResourceIamPolicy if we're not using getProject?

@rileykarson
Copy link
Collaborator

Not yet - we would need to modify it to conditionally use getProject, which is worth doing eventually probably.

@ghost
Copy link

ghost commented May 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.