Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GOOGLE_XPN_HOST_PROJECT env variable #715

Closed
danawillow opened this issue Nov 9, 2017 · 3 comments · Fixed by #760 or #815
Closed

Remove GOOGLE_XPN_HOST_PROJECT env variable #715

danawillow opened this issue Nov 9, 2017 · 3 comments · Fixed by #760 or #815

Comments

@danawillow
Copy link
Contributor

Even though this is only used in one test, we obnoxiously require it to be set when running any test. Since we have XPN support now, we can actually set up an XPN project in the test that uses this variable so we don't need it anymore. Or if we don't feel like doing that, we can at the very least only check it in the test where it gets used.

@danawillow
Copy link
Contributor Author

#760 makes the variable no longer mandatory for all tests, keeping this open to track removing it altogether.

@rosbo
Copy link
Contributor

rosbo commented Nov 17, 2017

Oupps, it was automatically closed when I merged #760

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants