Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform tries to update google_compute_instance_template instead of recreating #6317

Closed
Assignees
Labels

Comments

@danpospisil
Copy link

danpospisil commented May 7, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

When trying to update network_interface - access_config - network_tier option, terraform tries to update the resource instead of destroying and recreating the resource

Terraform Version

Terraform v0.12.24

  • provider.google v3.20.0

Affected Resource(s)

  • google_compute_instance_template

Terraform Configuration Files

Original:

resource "google_compute_instance_template" "instance_template" {
  machine_type = "e2-micro"
  disk {
    source_image = "debian-cloud/debian-9"
  }
  network_interface {
    network = "default"
    access_config {
        network_tier = "STANDARD"
    }
  }
  lifecycle {
    create_before_destroy = true
  }
}

Update after original was applied:

resource "google_compute_instance_template" "instance_template" {
  machine_type = "e2-micro"
  disk {
    source_image = "debian-cloud/debian-9"
  }
  network_interface {
    network = "default"
    access_config {
        network_tier = "PREMIUM"
    }
  }
  lifecycle {
    create_before_destroy = true
  }
}

Expected Behavior

Instance template should be recreated - not updated

Actual Behavior

Terraform tries to update the resource:

google_compute_instance_template.instance_template: Modifying... [id=projects/terraform-test-274919/global/instanceTemplates/terraform-20200507210144048800000001]

Error: doesn't support update

  on main.tf line 14, in resource "google_compute_instance_template" "instance_template":
  14: resource "google_compute_instance_template" "instance_template" {

Steps to Reproduce

Create google_compute_instance_template with network_tier set to STANDARD
run apply
change the network_tier option to PREMIUM
apply will fail

Important Factoids

This was supposed to fixed in PR#11548 but it doesnt seem to work

References

hashicorp/terraform#11548

@ghost ghost added the bug label May 7, 2020
@edwardmedia edwardmedia self-assigned this May 7, 2020
@edwardmedia
Copy link
Contributor

@ndmckinley I can repro above issue with Error: doesn't support update
Additional Info:

  1. if I change other attributes (like adding metadata) along with the upgrade on network_tier, the apply succeeds. PREMIUM is showing up on network_tier
  2. changes on create_before_destroy appear not working.

@ghost
Copy link

ghost commented Jun 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.