Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute_instance.network_interface doesn't get set on read #537

Closed
paddycarver opened this issue Oct 5, 2017 · 3 comments
Closed

compute_instance.network_interface doesn't get set on read #537

paddycarver opened this issue Oct 5, 2017 · 3 comments
Assignees
Labels

Comments

@paddycarver
Copy link
Contributor

As pointed out by @PeterMilley, #491 accidentally removed the d.Set line for the network_interfaces field in google_compute_instance, probably misreading it as a network field. That should be reintroduced to make computed fields work again, as well as to make importing accurate.

@paddycarver paddycarver added the bug label Oct 5, 2017
@paddycarver paddycarver self-assigned this Oct 5, 2017
@PeterMilley
Copy link
Contributor

#519 is likely the same issue (I was going to file an issue myself before I found that).

@paddycarver
Copy link
Contributor Author

Ah, thanks, poor reading on my part. Closing out in favor of #519.

luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this issue May 21, 2019
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants