Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_cloudbuild_trigger is missing some parameters #5108

Closed
jackivanov opened this issue Dec 7, 2019 · 5 comments
Closed

google_cloudbuild_trigger is missing some parameters #5108

jackivanov opened this issue Dec 7, 2019 · 5 comments

Comments

@jackivanov
Copy link

jackivanov commented Dec 7, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The resource is missing some parameters that described here (ie: options. artifacts, etc)

New or Affected Resource(s)

  • google_cloudbuild_trigger

Potential Terraform Configuration

resource "google_cloudbuild_trigger" "app" {
  project     = google_project.app.id
  description = "Build app"

  trigger_template {
    project_id = google_project.app.id
    repo_name  = "app"
    tag_name   = var.tag_name
  }

  build {
    step {
      name = "gcr.io/cloud-builders/docker"
      id   = "Build"
      args = [
        "build",
        "-f", "Dockerfile",
        "-t", "eu.gcr.io/$PROJECT_ID/app:latest",
        ".",
      ]
    }

    images = [
      "eu.gcr.io/$PROJECT_ID/app:latest",
    ]

    options = {
      machineType = "N1_HIGHCPU_8"
    }
  }
}

References

@ghost ghost added the enhancement label Dec 7, 2019
@slevenick slevenick added this to the Goals milestone Dec 9, 2019
@preston-hf
Copy link

It would be nice if we could set the logsBucket at least. Cloud build is almost useless on a team without being able to specify this parameter, since the default logsBucket requires Owner permission on the project to see the logs.

@achew22
Copy link

achew22 commented May 27, 2020

Is there a timeline for these parameters? In particular without logsBucket being set, it's very difficult to use this on a team.

I'm trying to gauge if we should hack around it or if the enhancements work on our timescale.

Thanks so much!

@AlfatahB
Copy link
Contributor

b/262663909

@AlfatahB
Copy link
Contributor

I've looked into this issue and the following are the details that I have found out:

  • It seems like this issue requests to add support for multiple fields in the google_cloudbuild_trigger resource.

The resource is missing some parameters that described here (ie: options. artifacts, etc)

Hence, Closing this issue. If there is a need to support other fields, then please open a new issue that briefly describes the fields to be supported. Thanks!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants