Exclusively use (Terraform) taints to manage GKE clusters in the error state

[rileykarson]

Affected Resource(s)

• google_container_cluster
• google_container_node_pool

Today, if a GKE cluster enters an error state during Create we delete the cluster during Create. With 0.12, it's possible to remove that behaviour. Errors during Create cause the cluster to get tainted, causing Terraform to delete the cluster.

---

As an additional extension, it may be possible to extend this behaviour to cover clusters in more error states. Read currently fails when a cluster is in an error state, so we may be able to taint the cluster in these cases.

Note that some error states may be recoverable. In those cases, we shouldn't taint the cluster.

I don't believe tainting in Read possible currently, so an issue will need to be filed at https://github.com/hashicorp/terraform-plugin-sdk.

---

Added to 4.0.0 so this gets evaluated then, it's a significant behaviour change that could-be-but-probably-isn't compatible.

b/299442706

[rileykarson]

Updated to exclusively. https://github.com/terraform-providers/terraform-provider-google/blob/master/google/resource_container_cluster.go#L1019 needs to be updated, https://github.com/terraform-providers/terraform-provider-google/blob/master/google/resource_container_cluster.go#L1057 is already using taints.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.