Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support rootPassword property of google_sql_database_instance for SQL Server #4776

Closed
sho-abe opened this issue Oct 30, 2019 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#2592

Comments

@sho-abe
Copy link

sho-abe commented Oct 30, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Since October 15th, Cloud SQL for SQL Server has been public beta.
I tried to create SQL Server instance with google_sql_database_instance, but I could not create it with the following error.

google_sql_database_instance.mssql: Creating...

Error: Error, failed to create instance mssql-tf: googleapi: Error 400: Missing parameter: Root Password., required

  on sql.tf line 1, in resource "google_sql_database_instance" "mssql":
   1: resource "google_sql_database_instance" "mssql" {

Apparently, when creating SQL Server with REST API, it seems that "rootPassword" is required in RequestBody.
The google_sql_database_instance can't set "rootPassword" currently, so I wourd like to need that feature.

New or Affected Resource(s)

  • google_sql_database_instance

Potential Terraform Configuration

resource "google_sql_database_instance" "mssql" {
  name             = "mssql-tf"
  region           = "asia-northeast1"
  database_version = "SQLSERVER_2017_WEB"
  root_password    = "password" ## can be set!!

  settings {
    tier      = "db-custom-2-3840"
    disk_size = 10
    disk_type = "PD_SSD"
  }

}

resource "google_sql_database" "mssql" {
  instance = google_sql_database_instance.mssql.name
  name     = "testdb"
  collation = "UTF-8"
}

References

@ghost ghost added the enhancement label Oct 30, 2019
@sho-abe sho-abe changed the title Add support rootPassword property or google_sql_database_instance for SQL Server Add support rootPassword property of google_sql_database_instance for SQL Server Oct 30, 2019
kopachevsky added a commit to kopachevsky/magic-modules that referenced this issue Nov 22, 2019
… SQL Server

Added root_password parameter required MS SQL Server instance creation, ignored MySQL and PostgreSQL.
Fix added both to beta and ga providers.

Fixes #hashicorp/terraform-provider-google/issues/4776
kopachevsky added a commit to kopachevsky/magic-modules that referenced this issue Nov 25, 2019
… SQL Server

Added root_password parameter required MS SQL Server instance creation, ignored MySQL and PostgreSQL.
Fix added both to beta and ga providers.

Fixes #hashicorp/terraform-provider-google/issues/4776
modular-magician pushed a commit to kopachevsky/magic-modules that referenced this issue Nov 26, 2019
… SQL Server

Added root_password parameter required MS SQL Server instance creation, ignored MySQL and PostgreSQL.
Fix added both to beta and ga providers.

Fixes #hashicorp/terraform-provider-google/issues/4776
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant