Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP IAM Binding with Conditions #2909

Closed
ghost opened this issue Jan 22, 2019 · 17 comments · Fixed by GoogleCloudPlatform/magic-modules#2846
Closed

GCP IAM Binding with Conditions #2909

ghost opened this issue Jan 22, 2019 · 17 comments · Fixed by GoogleCloudPlatform/magic-modules#2846

Comments

@ghost
Copy link

ghost commented Jan 22, 2019

This issue was originally opened by @parmarsumit as hashicorp/terraform#20078. It was migrated here as a result of the provider split. The original body of the issue is below.


@nat-henderson
Copy link
Contributor

@parmasurmit - do you mean that you would like the existing IAM resources to support an optional "condition" field, where you could specify freeform conditions as described in https://cloud.google.com/iam/docs/conditions-overview?

@parmarsumit
Copy link

parmarsumit commented Jan 24, 2019 via email

@primeroz
Copy link

This is really important for us as well.

Is there any roadmap for this feature ?

@redbaron
Copy link

@danawillow , that PR seems to be stalled :( Do you plan to continue work on it or it can be picked up by someone else? What is left to do to make it mergeable?

@danawillow
Copy link
Contributor

Yup, I think I'll be able to get to it later this week, or next week at the latest. If I don't, I'll publish a draft of what I have so far so someone else can take it over.

@dancmeyers
Copy link

Just another voice to say this would be really handy for us as well. I just got pointed to the docs about IAM conditions by our Google account manager and thought it was exactly what we needed, but everything else we have is in Terraform and we don't want a separate process just for this.

@morgante
Copy link

@danawillow is this on the team radar? I saw you added it for service accounts, could we roll it out for projects as well?

@danawillow
Copy link
Contributor

Yup, my plan is to add it for every resource that we can before our next release so they all go out together.

@dancmeyers
Copy link

Amazing :D It is GCS access permissions we wanted it for, so that's great to hear!

@danawillow
Copy link
Contributor

Quick update- I wasn't able to get the rest out in time for this recent release, so my new plan is to add it for every resource that we can before our next release.

@janmasarik
Copy link

So next release (2.21.0) @danawillow? :-)

We're also waiting for this and it would be amazing to have it there

@danawillow
Copy link
Contributor

GCS was harder than I expected (I'm doing it by migrate resources to magic modules in order to avoid a ton of copy/pasting) and we're pushing real hard towards 3.0 right now, so probably not until 3.1 unfortunately.

@janmasarik
Copy link

Thanks a lot for the prompt response, but not even GoogleCloudPlatform/magic-modules#2633 will be released before 3.0? 😞

@janmasarik
Copy link

Wow, I totally overlooked that! Thank you very much! :)

@danawillow
Copy link
Contributor

GoogleCloudPlatform/magic-modules#2794 is out for review for GCS. After that, I believe the only remaining product is KMS. Once that's done, I'll close this issue out, and as more GCP products support conditions they can be requested separately.

@ghost
Copy link
Author

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants