-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataflow] Improve documentation on the use of the parameters argument. #17612
[Dataflow] Improve documentation on the use of the parameters argument. #17612
Comments
Is there a way to assign this to myself? |
@damondouglas I can assign you. Normally we would forward this as a new ticket, but I see that this is an action item from the previous issue #17570. Would you like to close the other issue? And do you need us to forward this one as well? |
Note from triage: In case it's relevant, we did change the behavior of the parameters field slightly in 5.0: https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/version_5_upgrade#resource-google_dataflow_flex_template_job |
@melinath Thank you for this helpful information. The noted behavior change does not change the fix strategy for #17612. I will cc you on the PR in case you do not get alerts anyway. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Terraform Version
This issue is not related to a specific terraform version.
Affected Resource(s)
dataflow_flex_template_job
Terraform Configuration
No response
Debug Output
No response
Expected Behavior
The documentation on parameters could probably state: "string / string Key/Value pairs to be passed to the Dataflow job that are specific to the template.", replacing the phrase "Additional pipeline options such as serviceAccount, workerMachineType, etc can be specified here." with "Parameters common to all Dataflow jobs such as serviceAccount, etc should be assigned using this resource block's designated parameter."
Actual Behavior
No response
Steps to reproduce
No response
Important Factoids
No response
References
No response
b/331217711
The text was updated successfully, but these errors were encountered: