Feature request: Allow vcenter_network to be set by users on google_gkeonprem_vmware_cluster

[bateau84]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

When creating google_gkeonprem_vmware_cluster it is necessary to define the vmware network name the cluster and node-pools are created in.
As of now it is inherited from the admin cluster, however it is needed to not place the user-clusters in the same network as the admin-cluster and be able to define it manually.

New or Affected Resource(s)

• google_gkeonprem_vmware_cluster
• google_gkeonprem_vmware_node_pool

Potential Terraform Configuration

resource "google_gkeonprem_vmware_cluster" "gkee_onprem_cluster" {
...
  network_config {
    ...
    vcenter_network = "some-network-name"
   ...
  }
...
}

References

• API: https://cloud.google.com/anthos/clusters/docs/on-prem-api/reference/rest/v1/projects.locations.vmwareClusters
• Docs for the field : https://cloud.google.com/anthos/clusters/docs/on-prem-api/reference/rest/v1/projects.locations.vmwareClusters#vmwarenetworkconfig

b/317042838

[SarahFrench]

Notes from triage: The field is present on the google_gkeonprem_vmware_cluster resource, but currently it's implemented as an output. The field will need to be changed to be Optional + Computed.

Edit: see comments below - in the API this field can only be an output currently, but when configuring a cluster via config files the value can be changed

[mikkel3000]

Notes from triage: The field is present on the google_gkeonprem_vmware_cluster resource, but currently it's implemented as an output. The field will need to be changed to be Optional + Computed.

I have tested my pull request by building the provider locally.
While setting network_config.vcenter_network is accepted, it does not seem to have any effect on the created kubernetes cluster.
Are you sure the underlying api supports it? Where can I find the reference?

Edit: if this is the api reference, it does not seem to be supported.

However, it is supported here.

[SarahFrench]

Hi @mikkelnygard - That's the correct API reference, and you're correct that making that field user-controlled is unsupported. network_config.vcenter_network is output only, so the note from triage was incorrect. Sorry for misleading you!

Unfortunately we're constrained by the API, so if a feature is supported via config files and gkectl but not by the API then we can only make a feature request to the service team that manages the API.

[mikkel3000]

Hi @mikkelnygard - That's the correct API reference, and you're correct that making that field user-controlled is unsupported. network_config.vcenter_network is output only, so the note from triage was incorrect. Sorry for misleading you!

Unfortunately we're constrained by the API, so if a feature is supported via config files and gkectl but not by the API then we can only make a feature request to the service team that manages the API.

Ok, thank you for the clarification.
This is unfortunately a blocker for us, and means we can not use the terraform provider.
Can you make that feature request?

[bateau84]

Any update on this issue @SarahFrench ?

[SarahFrench]

@bateau84 No updates I'm afraid! This issue has been forwarded to the relevant service team to act on. I'm unable to contact them for an update.

[bateau84]

It seems like this option is in the latest release of the provider? can someone confirm? :)

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.