Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample for alert & notification in google_monitoring_uptime_check_config #12298

Open
andrejohansson opened this issue Aug 11, 2022 · 2 comments

Comments

@andrejohansson
Copy link

andrejohansson commented Aug 11, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

GCP supports setting up alerts when defining an uptime check but the terraform provider does not seem to have any section regarding this:

image

New or Affected Resource(s)

google_monitoring_uptime_check_config

Potential Terraform Configuration

  alerts {
    name = "Alert name"
    duration = "1m"
    notification_channel = my_channel.id
  }

References

b/315329689

@ScottSuarez
Copy link
Collaborator

It doesn't look like the api for uptimeCheckConfigs supports this. I'm guessing they internally set it up with an alertPolicies resource. If you have an idea you can try to set this up with google_monitoring_alert_policy, but let me reach out to the owning team to see how they do this.

@ScottSuarez
Copy link
Collaborator

It looks like they set a filter on alert policy to track the uptimecheck_config

metric.type="monitoring.googleapis.com/uptime_check/check_passed" AND metric.label.check_id="${checkId}"

@ScottSuarez ScottSuarez changed the title Support for alert & notification in google_monitoring_uptime_check_config Add sample for alert & notification in google_monitoring_uptime_check_config Aug 16, 2022
@ScottSuarez ScottSuarez removed their assignment Aug 16, 2022
@c2thorn c2thorn added this to the Goals milestone Aug 22, 2022
@github-actions github-actions bot added forward/review In review; remove label to forward service/monitoring-uptime labels Aug 17, 2023
@ScottSuarez ScottSuarez removed the forward/review In review; remove label to forward label Dec 2, 2023
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Nov 26, 2024
)

[upstream:6eb3aa904157f7fe8e11671c669f2b6f5a355c18]

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit that referenced this issue Nov 26, 2024
)

[upstream:6eb3aa904157f7fe8e11671c669f2b6f5a355c18]

Signed-off-by: Modular Magician <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants