Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for regional GKE clusters in google_container_cluster #1170

Closed
ashish-amarnath opened this issue Mar 8, 2018 · 10 comments
Closed
Labels
enhancement forward/review In review; remove label to forward service/container

Comments

@ashish-amarnath
Copy link
Contributor

Hi there,

Thank you for opening an issue. Please note that we try to keep the Terraform issue tracker reserved for bug reports and feature requests. For general usage questions, please see: https://www.terraform.io/community.html.

Terraform Version

Terraform v0.11.2 and upwards

  • provider.google

Affected Resource(s)

Please list the resources as a list, for example:

  • google_container_cluster

Expected Behavior

This is a feature request to add support for Regional GKE clusters on creating/updating a container cluster.

References

This document describes what needs to be done
https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/projects.locations.clusters

@danawillow
Copy link
Contributor

Unassigning myself because @ashish-amarnath mentioned in slack they were planning on implementing this.

@danawillow danawillow removed their assignment Mar 8, 2018
@Stono
Copy link

Stono commented Mar 9, 2018

@ashish-amarnath do we know when this is coming? As regional clusters are now beta it'd be awesome to make use of them.

@ashish-amarnath
Copy link
Contributor Author

@Stono I don't have an ETA at the moment. Based on our plans this might be a couple of weeks away.
I'll keep this issue updated.

@ashish-amarnath
Copy link
Contributor Author

@danawillow I was able to put together an initial set of changes for this. I've opened a WIP PR at #1181 hoping to get some initial feedback on the approach.

@wmuizelaar
Copy link

I guess this is doubling with #829 ?

@danawillow
Copy link
Contributor

Fixed in #1181

@Stono
Copy link

Stono commented Apr 5, 2018 via email

@danawillow
Copy link
Contributor

@Stono released it today!

@Stono
Copy link

Stono commented Apr 6, 2018 via email

@ghost
Copy link

ghost commented Nov 19, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 19, 2018
@github-actions github-actions bot added service/container forward/review In review; remove label to forward labels Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement forward/review In review; remove label to forward service/container
Projects
None yet
Development

No branches or pull requests

4 participants