Skip to content

Commit

Permalink
Unbreak TestAccBigQueryDataset_withProvider5 (#12146) (#20074)
Browse files Browse the repository at this point in the history
[upstream:832a0d68eb60a08320222d2819261645768d7a17]

Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
modular-magician authored Oct 29, 2024
1 parent 6ca01f4 commit db68b81
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .changelog/12146.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
```release-note:none
```
15 changes: 14 additions & 1 deletion google/services/bigquery/resource_bigquery_dataset_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ func TestAccBigQueryDataset_withProvider5(t *testing.T) {
CheckDestroy: testAccCheckBigQueryDatasetDestroyProducer(t),
Steps: []resource.TestStep{
{
Config: testAccBigQueryDataset_withoutLabels(datasetID),
Config: testAccBigQueryDataset_withoutLabelsV4(datasetID),
ExternalProviders: oldVersion,
Check: resource.ComposeTestCheckFunc(
resource.TestCheckNoResourceAttr("google_bigquery_dataset.test", "labels.%"),
Expand Down Expand Up @@ -511,6 +511,19 @@ resource "google_bigquery_dataset" "test" {
`, datasetID)
}

func testAccBigQueryDataset_withoutLabelsV4(datasetID string) string {
return fmt.Sprintf(`
resource "google_bigquery_dataset" "test" {
dataset_id = "%s"
friendly_name = "foo"
description = "This is a foo description"
location = "EU"
default_partition_expiration_ms = 3600000
default_table_expiration_ms = 3600000
}
`, datasetID)
}

func testAccBigQueryDataset(datasetID string) string {
return fmt.Sprintf(`
resource "google_bigquery_dataset" "test" {
Expand Down

0 comments on commit db68b81

Please sign in to comment.