storage bucket IAM diff suppress (#3324) (#6019)

Signed-off-by: Modular Magician <[email protected]>
hashicorp · Mar 31, 2020 · cbe367e · cbe367e
1 parent 4009443
commit cbe367e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changelog/3324.txt b/.changelog/3324.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+storage: fixed an issue where `google_storage_bucket_iam_member` showed a diff for bucket self links
+```
diff --git a/google/iam_storage_bucket.go b/google/iam_storage_bucket.go
@@ -26,10 +26,14 @@ var StorageBucketIamSchema = map[string]*schema.Schema{
 		Type:             schema.TypeString,
 		Required:         true,
 		ForceNew:         true,
-		DiffSuppressFunc: compareSelfLinkOrResourceName,
+		DiffSuppressFunc: StorageBucketDiffSuppress,
 	},
 }
 
+func StorageBucketDiffSuppress(_, old, new string, _ *schema.ResourceData) bool {
+	return compareResourceNames("", old, new, nil)
+}
+
 type StorageBucketIamUpdater struct {
 	bucket string
 	d      *schema.ResourceData