Skip to content

Commit

Permalink
Clean up fwtransport test missing error check (#11194) (#18816)
Browse files Browse the repository at this point in the history
[upstream:dc0429af5fff9ea131b3e8c4df7f2c73ea8d458a]

Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
modular-magician authored Jul 23, 2024
1 parent 3069cba commit c7165ac
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .changelog/11194.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:none
none
```
3 changes: 3 additions & 0 deletions google/fwtransport/framework_config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,9 @@ func TestFrameworkProvider_LoadAndValidateFramework_credentials(t *testing.T) {
}
t.Fatalf("did not expect error, but [%d] error(s) occurred", diags.ErrorsCount())
}
if tc.ExpectError && !diags.HasError() {
t.Fatalf("expected error, but no errors occurred")
}
if !data.Credentials.Equal(tc.ExpectedDataModelValue) {
t.Fatalf("want credentials to be `%s`, but got the value `%s`", tc.ExpectedDataModelValue, data.Credentials.String())
}
Expand Down

0 comments on commit c7165ac

Please sign in to comment.