ForceOverride as ignore read as it does not appear in response (#4304) (

#8026) * ForceOverride as ignore read as it does not appear in response * Update ignore to work on the flattener * Remove beta Signed-off-by: Modular Magician <[email protected]>
hashicorp · Dec 16, 2020 · 9705ef2 · 9705ef2
1 parent b774178
commit 9705ef2
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/.changelog/4304.txt b/.changelog/4304.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+cloudrun: fixed a permanent diff on `google_cloud_run_domain_mapping` `spec.force_override` field
+```
diff --git a/google/resource_cloud_run_domain_mapping.go b/google/resource_cloud_run_domain_mapping.go
@@ -625,7 +625,8 @@ func flattenCloudRunDomainMappingSpec(v interface{}, d *schema.ResourceData, con
 	return []interface{}{transformed}
 }
 func flattenCloudRunDomainMappingSpecForceOverride(v interface{}, d *schema.ResourceData, config *Config) interface{} {
-	return v
+	// We want to ignore read on this field, but cannot because it is nested
+	return d.Get("spec.0.force_override")
 }
 
 func flattenCloudRunDomainMappingSpecRouteName(v interface{}, d *schema.ResourceData, config *Config) interface{} {

diff --git a/google/resource_cloud_run_domain_mapping_generated_test.go b/google/resource_cloud_run_domain_mapping_generated_test.go
@@ -78,9 +78,6 @@ resource "google_cloud_run_domain_mapping" "default" {
 
   metadata {
     namespace = "%{namespace}"
-    annotations = {
-      "run.googleapis.com/launch-stage" = "BETA"
-    }
   }
 
   spec {

diff --git a/website/docs/r/cloud_run_domain_mapping.html.markdown b/website/docs/r/cloud_run_domain_mapping.html.markdown
@@ -64,9 +64,6 @@ resource "google_cloud_run_domain_mapping" "default" {
 
   metadata {
     namespace = "my-project-name"
-    annotations = {
-      "run.googleapis.com/launch-stage" = "BETA"
-    }
   }
 
   spec {