Fix functions build_environment_variable updating (#5381) (#10447)

Signed-off-by: Modular Magician <[email protected]>
hashicorp · Oct 29, 2021 · 8c69e94 · 8c69e94
1 parent 98d66cc
commit 8c69e94
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/.changelog/5381.txt b/.changelog/5381.txt
@@ -0,0 +1,3 @@
+```release-note:none
+
+```
diff --git a/google/resource_cloudfunctions_function.go b/google/resource_cloudfunctions_function.go
@@ -617,7 +617,7 @@ func resourceCloudFunctionsUpdate(d *schema.ResourceData, meta interface{}) erro
 	}
 
 	if d.HasChange("build_environment_variables") {
-		function.EnvironmentVariables = expandEnvironmentVariables(d)
+		function.BuildEnvironmentVariables = expandBuildEnvironmentVariables(d)
 		updateMaskArr = append(updateMaskArr, "buildEnvironmentVariables")
 	}
 

diff --git a/google/resource_cloudfunctions_function_test.go b/google/resource_cloudfunctions_function_test.go
@@ -620,7 +620,7 @@ resource "google_cloudfunctions_function" "function" {
     TEST_ENV_VARIABLE = "test-env-variable-value"
   }
   build_environment_variables = {
-    TEST_ENV_VARIABLE = "test-env-variable-value"
+    TEST_ENV_VARIABLE = "test-build-env-variable-value"
   }
   max_instances = 10
 }
@@ -660,8 +660,8 @@ resource "google_cloudfunctions_function" "function" {
     NEW_ENV_VARIABLE  = "new-env-variable-value"
   }
   build_environment_variables = {
-    TEST_ENV_VARIABLE = "test-env-variable-value"
-    NEW_ENV_VARIABLE  = "new-env-variable-value"
+    TEST_ENV_VARIABLE = "test-build-env-variable-value"
+    NEW_ENV_VARIABLE  = "new-build-env-variable-value"
   }
   max_instances = 15
 }