Apply dsf to google_compute_health_check port value with no portspec (#…

…4143) (#7623) Signed-off-by: Modular Magician <[email protected]>
hashicorp · Oct 23, 2020 · 6655ef4 · 6655ef4
1 parent 1671926
commit 6655ef4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.changelog/4143.txt b/.changelog/4143.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+compute: fixed an issue where `google_compute_health_check` `port` values caused a diff when `port_specification` was unset or set to `""`
+```
diff --git a/google/resource_compute_health_check.go b/google/resource_compute_health_check.go
@@ -101,7 +101,7 @@ func portDiffSuppress(k, old, new string, d *schema.ResourceData) bool {
 			newPort, _ := strconv.Atoi(new)
 
 			portSpec := d.Get(b[0] + ".0.port_specification")
-			if int64(oldPort) == defaultPort && newPort == 0 && portSpec == "USE_FIXED_PORT" {
+			if int64(oldPort) == defaultPort && newPort == 0 && (portSpec == "USE_FIXED_PORT" || portSpec == "") {
 				return true
 			}
 		}