fixed data_source_secret_manager_secret_version on its id (#3904) (#7098

) Co-authored-by: Edward Sun <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Edward Sun <[email protected]>
hashicorp · Aug 25, 2020 · 40bd46d · 40bd46d
1 parent d5c2dbf
commit 40bd46d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.changelog/3904.txt b/.changelog/3904.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+fixed data_source_secret_manager_secret_version on its id value
+```
diff --git a/google/data_source_secret_manager_secret_version.go b/google/data_source_secret_manager_secret_version.go
@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"log"
 	"regexp"
-	"time"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
 )
@@ -121,6 +120,6 @@ func dataSourceSecretManagerSecretVersionRead(d *schema.ResourceData, meta inter
 	}
 	d.Set("secret_data", string(secretData))
 
-	d.SetId(time.Now().UTC().String())
+	d.SetId(version["name"].(string))
 	return nil
 }