add timeouts (#5114) (#9937)

* add timeouts * update the default length of timeout Signed-off-by: Modular Magician <[email protected]>
hashicorp · Aug 27, 2021 · 3777aaf · 3777aaf
1 parent 39dd0ed
commit 3777aaf
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/.changelog/5114.txt b/.changelog/5114.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+storage: added support for timeouts on `google_storage_bucket_object`
+```
diff --git a/google/resource_storage_bucket_object.go b/google/resource_storage_bucket_object.go
@@ -7,6 +7,7 @@ import (
 	"log"
 	"os"
 	"strings"
+	"time"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 
@@ -27,6 +28,12 @@ func resourceStorageBucketObject() *schema.Resource {
 		Update: resourceStorageBucketObjectUpdate,
 		Delete: resourceStorageBucketObjectDelete,
 
+		Timeouts: &schema.ResourceTimeout{
+			Create: schema.DefaultTimeout(4 * time.Minute),
+			Update: schema.DefaultTimeout(4 * time.Minute),
+			Delete: schema.DefaultTimeout(4 * time.Minute),
+		},
+
 		Schema: map[string]*schema.Schema{
 			"bucket": {
 				Type:        schema.TypeString,

diff --git a/website/docs/r/storage_bucket_object.html.markdown b/website/docs/r/storage_bucket_object.html.markdown
@@ -92,6 +92,15 @@ exported:
 
 * `media_link` - (Computed) A url reference to download this object.
 
+## Timeouts
+
+This resource provides the following
+[Timeouts](/docs/configuration/resources.html#timeouts) configuration options:
+
+- `create` - Default is 4 minutes.
+- `update` - Default is 4 minutes.
+- `delete` - Default is 4 minutes.
+
 ## Import
 
 This resource does not support import.