Use Go Modules for golangci-lint, vendor 1.18.0 (#4550)

* Stash changes

* Vendoring

* Amend errcheck rules

* Add space

* Add back linters

* Remove -v flag

.golangci.yml

@@ -24,4 +24,4 @@ linters:
 
 linters-settings:
   errcheck:
-    ignore: github.com/hashicorp/terraform/helper/schema:ForceNew|Set,fmt:.*,io:Close,github.com/terraform-providers/terraform-provider-google/google:Set
+    ignore: github.com/hashicorp/terraform-plugin-sdk/helper/schema:ForceNew|Set,fmt:.*,io:Close,github.com/terraform-providers/terraform-provider-google/google:Set

.travis.yml

@@ -25,6 +25,7 @@ script:
 branches:
   only:
   - master
+
 matrix:
   fast_finish: true
   allow_failures:

GNUmakefile

@@ -30,8 +30,8 @@ lint:
 
 tools:
 	@echo "==> installing required tooling..."
-	GO111MODULE=off go get -u github.com/client9/misspell/cmd/misspell
-	GO111MODULE=off go get -u github.com/golangci/golangci-lint/cmd/golangci-lint
+	GO111MODULE=on go install github.com/client9/misspell/cmd/misspell
+	GO111MODULE=on go install github.com/golangci/golangci-lint/cmd/golangci-lint
 
 
 test-compile:

go.mod

@@ -4,10 +4,12 @@ require (
 	cloud.google.com/go/bigtable v1.0.0
 	cloud.google.com/go/pubsub v1.0.1 // indirect
 	github.com/apparentlymart/go-cidr v1.0.1
+	github.com/client9/misspell v0.3.4
 	github.com/davecgh/go-spew v1.1.1
 	github.com/dustinkirkland/golang-petname v0.0.0-20170921220637-d3c2ba80e75e // indirect
 	github.com/gammazero/deque v0.0.0-20180920172122-f6adf94963e4 // indirect
 	github.com/gammazero/workerpool v0.0.0-20181230203049-86a96b5d5d92
+	github.com/golangci/golangci-lint v1.18.0
 	github.com/hashicorp/errwrap v1.0.0
 	github.com/hashicorp/go-cleanhttp v0.5.1
 	github.com/hashicorp/go-multierror v1.0.0

tools.go

@@ -0,0 +1,8 @@
+// +build tools
+
+package main
+
+import (
+	_ "github.com/client9/misspell/cmd/misspell"
+	_ "github.com/golangci/golangci-lint/cmd/golangci-lint"
+)