Fix depends_on in test (#4397) (#8219)

* Fix depends_on in test * Add test regex fix for node pool * Add link to bug Signed-off-by: Modular Magician <[email protected]>
hashicorp · Jan 14, 2021 · 0a20c2c · 0a20c2c
1 parent 5201fe2
commit 0a20c2c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 14 deletions.
diff --git a/.changelog/4397.txt b/.changelog/4397.txt
@@ -0,0 +1,3 @@
+```release-note:none
+
+```
diff --git a/google/data_source_google_compute_instance_template_test.go b/google/data_source_google_compute_instance_template_test.go
@@ -155,14 +155,9 @@ resource "google_compute_instance_template" "c" {
 }
 
 data "google_compute_instance_template" "default" {
-  project = "%{project}"
+  // Hack to prevent depends_on bug triggering datasource recreate due to https://github.com/hashicorp/terraform/issues/11806
+  project = "%{project}${replace(google_compute_instance_template.a.id, "/.*/", "")}${replace(google_compute_instance_template.b.id, "/.*/", "")}${replace(google_compute_instance_template.c.id, "/.*/", "")}"
   filter  = "name eq test-template-c-.*"
-
-  depends_on = [
-    google_compute_instance_template.a,
-    google_compute_instance_template.b,
-    google_compute_instance_template.c,
-  ]
 }
 `, map[string]interface{}{"project": project, "suffix": suffix})
 }
@@ -234,15 +229,10 @@ resource "google_compute_instance_template" "c" {
 }
 
 data "google_compute_instance_template" "default" {
-  project = "%{project}"
+  // Hack to prevent depends_on bug triggering datasource recreate due to https://github.com/hashicorp/terraform/issues/11806
+  project = "%{project}${replace(google_compute_instance_template.c.id, "/.*/", "")}"
   filter      = "name eq test-template-.*"
   most_recent = true
-
-  depends_on = [
-    google_compute_instance_template.a,
-    google_compute_instance_template.b,
-    google_compute_instance_template.c,
-  ]
 }
 `, map[string]interface{}{"project": project, "suffix": suffix})
 }