Fix failing compute tests which use AccessConfigs (#1383)

hashicorp · Apr 25, 2018 · 0a02d8e · 0a02d8e
1 parent 7e5ce3f
commit 0a02d8e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/google/compute_instance_helpers.go b/google/compute_instance_helpers.go
@@ -106,7 +106,7 @@ func expandAccessConfigs(configs []interface{}) []*computeBeta.AccessConfig {
 			Type:  "ONE_TO_ONE_NAT",
 			NatIP: data["nat_ip"].(string),
 		}
-		if ptr, ok := data["public_ptr_domain_name"]; ok {
+		if ptr, ok := data["public_ptr_domain_name"]; ok && ptr != "" {
 			acs[i].SetPublicPtr = true
 			acs[i].PublicPtrDomainName = ptr.(string)
 		}

diff --git a/google/resource_compute_instance.go b/google/resource_compute_instance.go
@@ -1125,7 +1125,7 @@ func resourceComputeInstanceUpdate(d *schema.ResourceData, meta interface{}) err
 					Type:  "ONE_TO_ONE_NAT",
 					NatIP: d.Get(acPrefix + ".nat_ip").(string),
 				}
-				if ptr, ok := d.GetOk(acPrefix + ".public_ptr_domain_name"); ok {
+				if ptr, ok := d.GetOk(acPrefix + ".public_ptr_domain_name"); ok && ptr != "" {
 					ac.SetPublicPtr = true
 					ac.PublicPtrDomainName = ptr.(string)
 				}