migrating router-bgp-peer to be a handwritten resource (#9559) (#16682)

* Making router-bgp-peer as a handwritten resource * Adding sweeper file, removing example suffix from test files and adding resource in the handwritten section in provider * Removing unused import statements * Removing unused import statements from router_peer * Fix indentation --------- [upstream:99b5c55dd2b3f66b91a192e9a22a7ffe51a387b1] Signed-off-by: Modular Magician <[email protected]>
hashicorp · Dec 5, 2023 · 070e868 · 070e868
1 parent 0ecdc7f
commit 070e868
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 64 deletions.
diff --git a/.changelog/9559.txt b/.changelog/9559.txt
@@ -0,0 +1,3 @@
+```release-note:none
+Migrating resource from auto-generated to handwritten section
+```
diff --git a/google/provider/provider_mmv1_resources.go b/google/provider/provider_mmv1_resources.go
@@ -366,9 +366,9 @@ var handwrittenIAMDatasources = map[string]*schema.Resource{
 }
 
 // Resources
-// Generated resources: 347
+// Generated resources: 346
 // Generated IAM resources: 216
-// Total generated resources: 563
+// Total generated resources: 562
 var generatedResources = map[string]*schema.Resource{
 	"google_folder_access_approval_settings":                         accessapproval.ResourceAccessApprovalFolderSettings(),
 	"google_organization_access_approval_settings":                   accessapproval.ResourceAccessApprovalOrganizationSettings(),
@@ -569,7 +569,6 @@ var generatedResources = map[string]*schema.Resource{
 	"google_compute_resource_policy":                                 compute.ResourceComputeResourcePolicy(),
 	"google_compute_route":                                           compute.ResourceComputeRoute(),
 	"google_compute_router":                                          compute.ResourceComputeRouter(),
-	"google_compute_router_peer":                                     compute.ResourceComputeRouterBgpPeer(),
 	"google_compute_router_nat":                                      compute.ResourceComputeRouterNat(),
 	"google_compute_service_attachment":                              compute.ResourceComputeServiceAttachment(),
 	"google_compute_snapshot":                                        compute.ResourceComputeSnapshot(),
@@ -935,6 +934,7 @@ var handwrittenResources = map[string]*schema.Resource{
 	"google_compute_attached_disk":                  compute.ResourceComputeAttachedDisk(),
 	"google_compute_instance":                       compute.ResourceComputeInstance(),
 	"google_compute_disk_async_replication":         compute.ResourceComputeDiskAsyncReplication(),
+	"google_compute_router_peer":                    compute.ResourceComputeRouterBgpPeer(),
 	"google_compute_instance_from_template":         compute.ResourceComputeInstanceFromTemplate(),
 	"google_compute_instance_group":                 compute.ResourceComputeInstanceGroup(),
 	"google_compute_instance_group_manager":         compute.ResourceComputeInstanceGroupManager(),

diff --git a/google/services/compute/resource_compute_router_peer.go b/google/services/compute/resource_compute_router_peer.go
@@ -1,20 +1,5 @@
 // Copyright (c) HashiCorp, Inc.
 // SPDX-License-Identifier: MPL-2.0
-
-// ----------------------------------------------------------------------------
-//
-//     ***     AUTO GENERATED CODE    ***    Type: MMv1     ***
-//
-// ----------------------------------------------------------------------------
-//
-//     This file is automatically generated by Magic Modules and manual
-//     changes will be clobbered when the file is regenerated.
-//
-//     Please read more about how to change this file in
-//     .github/CONTRIBUTING.md.
-//
-// ----------------------------------------------------------------------------
-
 package compute
 
 import (

diff --git a/google/services/compute/resource_compute_router_peer_sweeper.go b/google/services/compute/resource_compute_router_peer_sweeper.go
@@ -1,20 +1,5 @@
 // Copyright (c) HashiCorp, Inc.
 // SPDX-License-Identifier: MPL-2.0
-
-// ----------------------------------------------------------------------------
-//
-//     ***     AUTO GENERATED CODE    ***    Type: MMv1     ***
-//
-// ----------------------------------------------------------------------------
-//
-//     This file is automatically generated by Magic Modules and manual
-//     changes will be clobbered when the file is regenerated.
-//
-//     Please read more about how to change this file in
-//     .github/CONTRIBUTING.md.
-//
-// ----------------------------------------------------------------------------
-
 package compute
 
 import (

diff --git a/...rce_compute_router_peer_generated_test.go → ...pute/resource_compute_router_peer_test.go b/...rce_compute_router_peer_generated_test.go → ...pute/resource_compute_router_peer_test.go
@@ -1,20 +1,5 @@
 // Copyright (c) HashiCorp, Inc.
 // SPDX-License-Identifier: MPL-2.0
-
-// ----------------------------------------------------------------------------
-//
-//     ***     AUTO GENERATED CODE    ***    Type: MMv1     ***
-//
-// ----------------------------------------------------------------------------
-//
-//     This file is automatically generated by Magic Modules and manual
-//     changes will be clobbered when the file is regenerated.
-//
-//     Please read more about how to change this file in
-//     .github/CONTRIBUTING.md.
-//
-// ----------------------------------------------------------------------------
-
 package compute_test
 
 import (
@@ -30,7 +15,7 @@ import (
 	transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
 )
 
-func TestAccComputeRouterBgpPeer_routerPeerRouterApplianceExample(t *testing.T) {
+func TestAccComputeRouterBgpPeer_routerPeerRouterAppliance(t *testing.T) {
 	t.Parallel()
 
 	context := map[string]interface{}{
@@ -43,7 +28,7 @@ func TestAccComputeRouterBgpPeer_routerPeerRouterApplianceExample(t *testing.T)
 		CheckDestroy:             testAccCheckComputeRouterBgpPeerDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
-				Config: testAccComputeRouterBgpPeer_routerPeerRouterApplianceExample(context),
+				Config: testAccComputeRouterBgpPeer_routerPeerRouterAppliance(context),
 			},
 			{
 				ResourceName:            "google_compute_router_peer.peer",
@@ -55,7 +40,7 @@ func TestAccComputeRouterBgpPeer_routerPeerRouterApplianceExample(t *testing.T)
 	})
 }
 
-func testAccComputeRouterBgpPeer_routerPeerRouterApplianceExample(context map[string]interface{}) string {
+func testAccComputeRouterBgpPeer_routerPeerRouterAppliance(context map[string]interface{}) string {
 	return acctest.Nprintf(`
 resource "google_compute_network" "network" {
   name                    = "tf-test-my-router%{random_suffix}-net"

diff --git a/website/docs/r/compute_router_peer.html.markdown b/website/docs/r/compute_router_peer.html.markdown
@@ -1,17 +1,4 @@
 ---
-# ----------------------------------------------------------------------------
-#
-#     ***     AUTO GENERATED CODE    ***    Type: MMv1     ***
-#
-# ----------------------------------------------------------------------------
-#
-#     This file is automatically generated by Magic Modules and manual
-#     changes will be clobbered when the file is regenerated.
-#
-#     Please read more about how to change this file in
-#     .github/CONTRIBUTING.md.
-#
-# ----------------------------------------------------------------------------
 subcategory: "Compute Engine"
 description: |-
   BGP information that must be configured into the routing stack to