Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tags cause notebooks instances to recreate #7086

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#17075

Release Note Template for Downstream PRs (will be copied)

notebooks: fixed an issue where default tags would cause a diff recreating `google_notebooks_instance` resources

Derived from GoogleCloudPlatform/magic-modules#10179

* add labels to runtime update test

* Add labels to ImportStateVerifyIgnore

* fix indentation

* fix tags cause notebooks instances to create

[upstream:aba1d05f1ea4bd7e93a485044fa19870bd887ddd]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 1a3d3b6 into hashicorp:main Mar 12, 2024
2 checks passed
@modular-magician modular-magician deleted the downstream-pr-aba1d05f1ea4bd7e93a485044fa19870bd887ddd branch November 16, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_notebooks_instance don't persist tags in state
1 participant