BQ - Support for External Data Tables #696
Conversation
ghost
added
There was a problem hiding this comment.
Generally, we'll want to add all the default values we can I think. I marked some, but not all cases where the API docs define one- we should? be able to set them all.
I refer to being able to set a value "safely"- what I mean there is related to how some APIs behave; sending a default will cause the API to return a nil value to indicate that it is using the default, instead of the default value. Terraform will diff and won't handle these cases well. We have some remediation, so if you're seeing this behaviour flag it and we'll work through the best solution.
| }, | ||
| // SkipLeadingRows: [Optional] The number of rows at the top | ||
| // of a CSV file that BigQuery will skip when reading the data. | ||
| "skip_leading_rows": { |
There was a problem hiding this comment.
Can we explicitly default to 0 as per the docs safely?
There was a problem hiding this comment.
Added this in GoogleCloudPlatform/magic-modules@1e5032f
|
I'll go through all the defaults and see what happens if I set those. |
|
Resolved in GoogleCloudPlatform/magic-modules@d5e59f3 |
modular-magician
force-pushed
the
codegen-pr-1466
branch
from
c5d137a to
1c276dd
Compare
Signed-off-by: Modular Magician <[email protected]>
modular-magician
force-pushed
the
codegen-pr-1466
branch
from
1c276dd to
48c4d5a
Compare
Original Author: @rickard-von-essen